Skip to content

Add encoding support via iconv-lite #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

minoru-nagasawa
Copy link
Contributor

When working with older Linux environments or systems that use non-UTF-8 encodings, terminal output can become garbled. To address this, I added an encoding option to the SSHFS configuration, allowing the extension to convert text via iconv-lite before displaying it.

What's Changed

  • Implemented an encoding property (e.g., "encoding": "EUC-JP") in the SSHFS config.
  • Any character encoding supported by iconv-lite (see list here) can be specified, ensuring proper display of non-UTF-8 text in the terminal.

Sample Configuration

{
    "sshfs.configs": [
        {
            "name": "NAME",
            "host": "localhost",
            "username": "user",
            "password": "pass",
            "encoding": "EUC-JP" // newly added encoding option
        }
    ]
}

image

@SchoofsKelvin SchoofsKelvin merged commit 1141b33 into SchoofsKelvin:master Feb 9, 2025
1 check passed
SchoofsKelvin added a commit that referenced this pull request Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants